[gstreamer-bugs] [Bug 498004] preset is ignored by lame plugin

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=498004

  GStreamer | gst-plugins-ugly | Ver: 0.10.7

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|slomo at circular-chaos.org    |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #16 from Sebastian Dröge  2008-07-29 16:57 UTC -------
I guess it was the quality setting which didn't have the default value.

Now we're using the default value almost everywhere:

2008-07-29  Sebastian Dröge  <sebastian.droege at collabora.co.uk>

        * ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init),
        (gst_lame_chain), (gst_lame_get_default_settings), (plugin_init):
        * ext/lame/gstlame.h:
        Get the defaults settings of LAME in the plugin initialization
        function and return FALSE here if something goes wrong. This removes
        the hacky failing instance init function.

        Use LAMEs default value for all settings instead of overwriting some
        of them. Overwriting some of them gives unexpected results if one only
        sets a preset. Fixes bug #498004.


Please check if everythnig works fine for you with latest CVS :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=498004.