[gstreamer-bugs] [Bug 542390] Implementation of DCCP Plugin for gstreamer

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=542390

  GStreamer | gst-plugins-bad | Ver: HEAD CVS




------- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev)  2008-07-30 12:19 UTC -------
1.)
gstdccpserversink.c: In Funktion »gst_dccp_server_delete_dead_clients«:
gstdccpserversink.c:226: Warnung: Implizite Deklaration der Funktion »free«

please add
#include <stdlib.h>
when using free().

On the other hand, please consider using g_malloc/g_free or instead of
Client *client = (Client *) malloc(sizeof(Client));
even
Client *client = (Client *) g_new(Client,1);

2.)
Please make all internal function static.
void *gst_dccp_server_accept_new_clients
Client *gst_dccp_server_create_client
...

3.)
All files should have copyright/license headers
src/gstdccp.c

4.)
We don't use // (c++) comments. Please convert them to /* */

5.)
Would be great if you could add some basic docs blobs to each element. Look at
plugins in gst-plugins-base for reference. A gst-launch pipleine would help to
tryout the functionality.

Thanks for the good work!


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=542390.