[gstreamer-bugs] [Bug 545501] New: Unable to get the parrent of a GstSubBuffer

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=545501

  GStreamer | gstreamer (core) | Ver: HEAD CVS
           Summary: Unable to get the parrent of a GstSubBuffer
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thijsvermeir at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


xvimagesink is using xvimagebuffer's (subclass of GstBuffer) for preventing
extra copies of the video buffer. But if an element want's to make the metadata
of the xvimagebuffer writable (that has ref_count > 1) it creates a SubBuffer
(Also a subclass of GstBuffer) and uses this one. So the info in the
xvimagebuffer is lost in this subbuffer and the xvimagesink uses the slow-copy
method to handle this subbuffer, but it should be able to handle this buffer
also as a fast-buffer.
Other elements that create a subclass of gstbuffer can have the same problem.

Now it is impossible for an element to get the parent of a subbuffer or even to
know that the buffer is a subbuffer because subbuffer is not public in the
header files.

2 possible solutions:
a) make the subbuffer type public so an element can check if it is using the
subbuffer and call a function like gst_sub_buffer_get_parent_buffer to get the
xvimagebuffer information.
b) create a gst_buffer_get_parent_buffer method that will give the parent if
the buffer is a subbuffer and return the buffer itself if not.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=545501.