[gstreamer-bugs] [Bug 537622] [matroskademux] Doesn't export covers (file attachments)

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=537622

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|slomo at circular-chaos.org    |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.9




------- Comment #3 from Sebastian Dröge  2008-06-16 10:57 UTC -------
Ok, fixed in CVS. The demuxer now posts GST_TAG_IMAGE if the mimetype is
"image/*" or if the filename contains the string "cover". Otherwise it posts
the attachment as GST_TAG_ATTACHMENT.

I'll add support for this in the muxer later.

2008-06-16  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst/matroska/Makefile.am:
        * gst/matroska/matroska-demux.c: (gst_matroska_demux_reset),
        (gst_matroska_demux_parse_attached_file),
        (gst_matroska_demux_parse_attachments),
        (gst_matroska_demux_parse_contents_seekentry),
        (gst_matroska_demux_loop_stream_parse_id):
        * gst/matroska/matroska-demux.h:
        * gst/matroska/matroska-ids.c: (gst_matroska_register_tags):
        * gst/matroska/matroska-ids.h:
        * gst/matroska/matroska.c: (plugin_init):
        Parse Attachments and post them as GST_TAG_IMAGE if we detect
        it as image and otherwise as GST_TAG_ATTACHMENT. Include filename
        and description of the attachments in the caps. Fixes bug #537622.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=537622.