[gstreamer-bugs] [Bug 519878] [basesink] Superfluous critical warning on segment format mismatches.

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=519878

  GStreamer | gstreamer (core) | Ver: 0.10.17




------- Comment #1 from Mark Nauwelaerts  2008-03-02 12:20 UTC -------
Created an attachment (id=106377)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=106377&action=view)
Possible patch.

* If gst_base_sink_get_sync_times decides no do_sync, do not bother to
calculate times (with possible side-effects).

In particular, (a.o.) filesink NULL'ifies get_times; does not want to sync.

Of course, these lines (or variations thereof) could be shifted around a bit.
There may be other approaches altogether, such as fixing (several?) other
elements, e.g. assuring a BYTE based segment gets sent first (which may be what
the critical warning is meant to point out in the first place :) ).

Anyway, these few lines (or alike) seem to make sense.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=519878.