[gstreamer-bugs] [Bug 396779] Preset interface for elements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=396779

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #51 from Jan Schmidt  2008-03-02 22:45 UTC -------
*sigh* Well, speaking for myself, I didn't look at it until now, no. We're all
busy people.

In general, I think it's a decent approach. I don't like:

* the gst_preset_create_preset function. A function to randomise the properties
which have been designated for presets doesn't seem a generally useful thing. I
think if such a thing is needed, it is better implemented as a utility function
which iterates the list of properties and randomises them.
* Doubling up GST_PARAM_CONTROLLABLE to mark properties which should be
included in the 'presets' set. It makes sense to have a simple way like that to
mark Preset-table properties, but I think it should be a separate flag. It
doesn't make sense, for example, for an MPEG encoder to have the GOP size be
controllable, but it makes sense for that to appear in a preset.
* The function of gst_preset_set/get_meta methods is obscure to me. What's the
point of being able to add generic tagged info to a preset? What does it mean
to the application? To the user? Is there a structure to them? What are the
rules?
* Christopher Dehais mentioned using GKeyFile for his RB equalizer presets,
which, along with GValue transformations seems like a better approach than the
existing manual serialising, deserialising and parsing code.
* There are some spelling mistakes in the docs, but those are easy to fix

There are some spurious docs bits in the gstreamer-sections.txt in the patch
above that shouldn't be there afaics:
+gst_element_class_set_meta_data
+gst_element_factory_get_meta_data_detail
+gst_query_new_qos
+gst_query_set_qos
+gst_query_parse_qos

You hopefully already realise this, but 1 day before the freeze really isn't
the right time to have brought this up again - poking us continuously since the
last release would have been better.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=396779.