[gstreamer-bugs] [Bug 396779] Preset interface for elements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=396779

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #55 from Christophe Dehais  2008-03-05 18:34 UTC -------
(In reply to comment #54)
> Christophe,
> 
> I hope I have not offended you, I feel a bit frustrated with this.

Not at all. I feel a bit ashamed of myself considering that I didn't helped
much and still haven't succeeded in polishing the RB equalizer plugin enough.
Time, Time, Time !


> Could you
> add links to viewvc of the rb sources where you implemented it? Maybe I can
> take some of the ideas there and bring them together in one of the next patch
> iterations.
> 

The patch is attached to Bug 76522. The relevant code is actually part of the
equalizer widget code:

http://bugzilla.gnome.org/attachment.cgi?id=99005&action=diff#plugins/equalizer/rb-equalizer.c_sec1

(search for the "Loading / exporting to Keyfile" comment at the end)

A sample GKeyfile is here:

http://bugzilla.gnome.org/attachment.cgi?id=99005&action=diff#plugins/equalizer/eq-presets.ini_sec1


> It would be great to later on migrate the rb presets to the gstreamer
> infrastructure, if we get consensus here.
> 
That would be great. Maybe how Banshee does this is worth a look too:

http://abock.org/2008/01/25/software-eq-in-banshee/

Also, If I understand your proposal well, all is needed is for the equalizer
element to implement the preset interface and then every app using it would
have access to the same presets ? If so, that would be quite easy to port the
current code in the RB plugin to use that (removing the customized preset
handling from the widget itself (which was not that nice an idea to start
with)).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=396779.