[gstreamer-bugs] [Bug 560345] New: gst_tag_list_get_string() may return NULL or empty string

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=560345

  GStreamer | gstreamer (core) | Ver: HEAD CVS
           Summary: gst_tag_list_get_string() may return NULL or empty
                    string
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


It seems like it's possible to add string tags with a NULL value or an empty
string to tag lists, which may result in gst_tag_list_get_string() returning
TRUE and a NULL string (see bug #560155).

That's unexpected to the caller and I can't think of any case where it makes
sense to have NULL strings in tags, or empty strings in tags (the empty string
case is from a totem buglet, see bug #559643).

I think we should either generally disallow NULL + "" for string values in tag
lists, or add a GstTagFlag to signal whether empty/null strings are allowed or
not, and then just not add such tags to tag lists.

GST_TAG_DATE is another case where NULL doesn't make sense.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=560345.