[gstreamer-bugs] [Bug 558124] [PLUGIN-MOVE] Move speexresample as audioresample2 to -base

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=558124

  GStreamer | gst-plugins-base | Ver: 0.10.22




------- Comment #4 from Sebastian Dröge  2008-11-21 14:52 UTC -------
The filter-length is twice the latency (in samples).

The problem here is, that audioresample allows a filter length between 0 and
1<<31 while speexresample hides the filter length internally behind the quality
parameter. quality 0 for example has a filter length of 8, quality 10 is 256
(quality also has influence on a few other internal parameters).

So we could map the filter length to the quality and simply have everything
above 256 map to quality 10.

Then we could replace audioresample by this without introducing a new element.
Downside is, that we have a useless property but we can of course remove that
in 0.11 then :)
If this sounds fine for everybody else we should do that instead of introducing
audioresample2.

For when to do the switch, I'd say now is a good time as the release is still
about one month in the future (and on IRC Tim said that he agrees that one
month is enough). We just need to get it moved to -base ASAP now.

I'd propose to move old audioresample to audioresample-old then, let it
register as audioresample-old and move speexresample to -base/gst/audioresample
and rename everything.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=558124.