[gstreamer-bugs] [Bug 562572] New: multiudpsink handles errors in _render() too aggressively

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=562572

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: multiudpsink handles errors in _render() too
                    aggressively
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: pkj at axis.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The code in gst_multiudpsink_render() treats all errors from sendto() except
EINTR, EAGAIN and EPERM as so serious that it returns GST_FLOW_ERROR. This
regardless of how many clients the multiudpsink has. This causes e.g. a
temporary network failure (ENETUNREACH) to terminate the pipeline, eventhough
it would have been better off just ignoring the error and then continue
delivery as soon as the network is restored.

The attached patch makes gst_multiudpsink_render() ignore all errors. This
works fine for cases where there is some other control protocol active (e.g.,
RTSP) which will terminate the pipeline if the client isn't reachable for a
while, but may be too lax for pure UDP pipelines. Maybe there needs to be a
property which controls whether errors from sendto() are to be ignored, or
propagated?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=562572.