[gstreamer-bugs] [Bug 556066] Last byte of FLAC image buffer chopped off

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Mon Oct 13 10:39:55 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556066

  GStreamer | gst-plugins-base | Ver: HEAD CVS

John Millikin changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #3 from John Millikin  2008-10-13 17:39 UTC -------
Sebastian: I don't think that patch is correct. The size of the buffer is
already set to image_data_len + 1 when the buffer is allocated. Keeping it at
image_data_len + 1 bytes will cause errors because a trailing NULL byte will be
appended to the image data and cause image parsers to fail. My patch preserves
the NULL byte, **and** returns the correct data length of binary data.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556066.




More information about the Gstreamer-bugs mailing list