[gstreamer-bugs] [Bug 550657] New element jasperdec

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=550657

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #117928|none                        |reviewed
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #2 from Tim-Philipp Müller  2008-09-05 13:46 UTC -------
This looks great, please commit it.

Some minor suggestions:

 - in _reset(), add a dec->mat=NULL and move the dec->codec_data=NULL
   up directly behind the unref.

 - the plugin name needs to be changed so it doesn't conflict with the
   existing "jasper" plugin from gst-plugins-farsight (maybe jasper-j2k?
   or jasper-jpeg2000? or just jpeg2000dec? or jjpeg2000dec? or ...?)

 - the element name also needs to be changed to something != "jasperdec",
   for the same reason

 - the element GType (structure name passed as first arg to GST_BOILERPLATE)
   also needs to be changed to something != "GstJasperDec", sadly


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=550657.