[gstreamer-bugs] [Bug 510354] post GST_MESSAGE_STRUCTURE_CHANGE when linking and unlinking pads

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Fri Sep 26 01:59:41 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=510354

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117248|none                        |needs-work
               Flag|                            |




------- Comment #16 from Wim Taymans  2008-09-26 08:59 UTC -------
Last patch starts to look good to me. 

There is one last thing, when we remove the element from the bin we would need
to remove all the pads that still have pending messages of this element. While
the pad always posts both start/done message pairs, it's possible that the
element is removed from the bin before the done message is posted, leaing the
start message in the bin still. It'll cause a leak because the pad cannot be
finalized because the message has a ref to it.

I would propose to add the element to the message structure for this purpose.

Update to patch welcome or wait till I take a look at this after the freeze.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=510354.




More information about the Gstreamer-bugs mailing list