[gstreamer-bugs] [Bug 553823] New: CodeStyle improvements and minor fixes to the DCCP plugin.

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Thu Sep 25 12:23:47 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=553823

  GStreamer | gst-plugins-bad | Ver: HEAD CVS
           Summary: CodeStyle improvements and minor fixes to the DCCP
                    plugin.
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: leandroal at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unversioned Enhancement
   GNOME milestone: Unspecified


There are many issues that should be fixed in the DCCP plugin since it is a
work in progress. The patch provided by this bug report touch in the following
points based on the codestyle gstreamer document:

1. should descend from an applicable base class if possible
2. make use of GST_BOILERPLATE macros
3. conform to the GStreamer coding style
4. use GST_(DEBUG/*)_OBJECT
5. use dashes in object property names to separate words
6. use correct value, name, nick for enums
7. use underscores in macros/function names/structs
8. should be correctly integrated with configure.ac
9. files implementing elements should be named according to their class name, 
e.g GstBaseSink -> gstbasesink.c
10. should show up correct in gst-inspect output; no warnings, no unknown
types, ...
11. The plug-in should be put in the correct location inside the module: sys/:
plug-ins that include system headers/link to system libraries; usually
platform-dependent as well name after whatever system "thing" they use (oss,
v4l, ...)
12. Plugin documentation following all the requirements of the codestyle
gstreamer document
13. The elements should not segfault under any circumstance. This includes:
wrong pipelines and bad data
14. All error conditions should be correctly handled using GST_ELEMENT_ERROR
and following practice outlined in
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstGError.html
15. plugin documentation needs to be added: see gstreamer/docs/README; section
on adding plugins and elements; "make update" in docs/plugins and commit the
new file; edit -docs.sgml and add an include for the file.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=553823.




More information about the Gstreamer-bugs mailing list