[gstreamer-bugs] [Bug 580585] rtpmux memleak

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=580585

  GStreamer | gst-plugins-bad | Ver: git




------- Comment #1 from Laurent Glayal  2009-04-28 11:35 UTC -------
in rtpmux.c:gst_rtp_mux_setcaps()
the code changed from :
  ret = gst_pad_set_caps (rtp_mux->srcpad, caps);
  gst_caps_unref (caps);

To

   ret = gst_pad_set_caps (rtp_mux->srcpad, caps);
   if (ret)
    gst_caps_replace (&padpriv->out_caps, caps);
  else
    gst_caps_unref (caps);

Shouldn't the gst_caps_unref be done every time, as gst_caps_replace()
increases caps refcount ?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=580585.