[gstreamer-bugs] [Bug 494528] Simplifications of the LAME plugin
bugzilla-daemon at bugzilla.gnome.org
Thu Apr 30 00:19:23 PDT 2009
If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
GStreamer | gst-plugins-ugly | Ver: git
------- Comment #9 from Gabriel Bouvigne 2009-04-30 07:19 UTC -------
(In reply to comment #8)
> > * on GST_EVENT_FLUSH_STOP, you are using a buffer of 7200. Why not always using
> > the same buffer value, both when encoding and on closing? (mp3_buffer_size =
> > 1.25 * num_samples + 7200)
> > 7200 will sometimes not be big enough.
> Gabriel, what should be used for the number of samples?
> lame_get_size_mp3buffer() can't be used because it doesn't include the cached
> raw samples that would be encoded by lame_encode_flush()...
Don't know what I was thinking. Indeed, in case of flush event, you don't have
any input sample.
You can then call lame_encode_flush in a loop, untill it returns 0.
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=494528.
More information about the Gstreamer-bugs