[gstreamer-bugs] [Bug 529741] Add ioctl-based CDDA plugin for Solaris

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=529741

  GStreamer | gst-plugins-bad | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109834|none                        |reviewed
               Flag|                            |
             Status|NEW                         |NEEDINFO




------- Comment #3 from Tim-Philipp Müller  2009-05-01 00:29 UTC -------
Hrm, this has been in bugzilla for a while. Are you still interested in getting
this in?

Some quick comments/questions:

 - is the code the latest version?

 - I think it should be called suncddasrc / GstSunCddaSrc
    and go into -bad/sys/sunccda or so as long as it's specific 
    to sun/solaris (or -bad/sys/suncdda if you shed the libhal
    dependency, see next item)

 - presumably the cd drive querying could be done via glib/gio
    these days (GVolumeMonitor)? (Not a requirement, just
    wondering)

 - is it ok to call ioctl() on the same file descriptor / device
    from multiple threads at the same time? (the speed
    changing would be done from the main application
    thread while the streaming thread accesses the drive
    as well)

 - please run gst-indent on the .c file (and only the .c file)

 - please change all the return (foo); into return foo; to
     match the rest of the GStreamer code base.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=529741.