[gstreamer-bugs] [Bug 539254] DVD with multiple angles switch angles during read

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=539254

  GStreamer | gst-plugins-ugly | Ver: git

Thomas Green changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tom78999 at gmail.com




------- Comment #3 from Thomas Green  2009-08-13 20:28 UTC -------
I can reproduce this with my Nausicaa DVD. As reported, sometimes the wrong
cell is returned and you end up watching the story-board instead, e.g. chapter
12 contains two cells (27 and 28) and it will always play cell 28 after
finishing 27 instead of skipping over it and on to the next chapter (Cell 28 is
the story-board).

It seems to me that the logic of the while loop should be reversed, i.e. it
should keep incrementing the current cell _until_ it finds a
BLOCK_MODE_LAST_CELL, and then add one to get the next cell. This certainly
seems to be how it is implemented in play_title.c (distributed with
libdvdread):

for( i = 0;; ++i ) {
  if( cur_pgc->cell_playback[ cur_cell + i ].block_mode
        == BLOCK_MODE_LAST_CELL ) {
    next_cell = cur_cell + i + 1;
    break;
  }
}

Very different, compared to how dvdreadsrc implements it:

while (pgc->cell_playback[cell].block_mode == BLOCK_MODE_LAST_CELL)
  ++cell;
return cell + 1;


Simply changing the condition in the while loop from == to != seems to fix this
for me. It seems to happily play through with either angle 1 or 2 now with no
switching back and forth.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=539254.