[gstreamer-bugs] [Bug 598682] make check fails due to fpsdisplaysink if xvimagesink does not exist

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=598682
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2009-12-17 09:42:56 UTC ---
This fixes the problem, but isn't very nice (IMHO).

For one, if you fail the state change, please use GST_ELEMENT_ERROR() to post
an appropriate error message  on the bus.

Secondly, it should be sufficient to do the check in the NULL -> READY state
change really. Maybe the autovideosink that's now created in the instance init
function should really be created there? Also, we should make sure the caller
doesn't try to change the video sink via g_object_set_property() while we're in
state > NULL, or something along those lines.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.