[gstreamer-bugs] [Bug 570581] New: osxvideosink: non-embedded mode is badly broken and should be removed

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=570581

  GStreamer | gst-plugins-good | Ver: git
           Summary: osxvideosink: non-embedded mode is badly broken and
                    should be removed
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Macintosh
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: msmith at xiph.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The default mode for osxvideosink is for it to create its own window. This does
not (and can not) work for any cocoa application - the sole purpose appears to
be to make it usable with gst-launch.

However, those codepaths are complex, mostly untested, and painful to maintain.

The patch I'm about to attach removes this mode, and makes the embedded mode
mandatory. It also fixes memory management to avoid leaks and occasional
crashes.

What do people think about this? Has anyone actually made real use of
osxvideosink without using the embedded mode?

(oleavr and twi seemed to give their approval for this idea on irc the other
day, so I'll commit this in a week or so if nobody objects)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=570581.