[gstreamer-bugs] [Bug 572480] unref and copy functions should not be macros

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=572480

  GStreamer | gstreamer (core) | Ver: git

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org
 Attachment #129093|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.23




------- Comment #2 from Sebastian Dröge  2009-02-22 17:53 UTC -------
commit cd1f18bd128319bcfd117bbceab92c8fcb6957c3
Author: Ali Sabil <ali.sabil at gmail.com>
Date:   Sun Feb 22 18:53:10 2009 +0100

    Use the correct unref function

commit 136cfb3bed4aa4d9e4b4ebd20c9562078addd9a7
Author: Ali Sabil <ali.sabil at gmail.com>
Date:   Sun Feb 22 18:51:08 2009 +0100

    Convert unref/copy functions of GstMiniObject subclasses to static inline
fu

    unref and copy functions are sometimes used as function
    pointers for example in the case of g_hash_table_new_full
    as a GDestroyNotify function.

    Currently GstBuffer, GstEvent, GstMessage and GstQuery
    define their respective unref and copy functions as
    macros, making use of gst_mini_object_unref/copy.
    This approach works very well for most cases, except
    for some automatically generated bindings (currently Vala),
    where the memory management semantics are defined
    declaratively.

    The possible solutions would be to either convert all
    the macros into static inline function, or change the
    signature of gst_mini_object_unref to take a void*
    instead of a GstMiniObject*.

    Fixes bug #572480.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=572480.