[gstreamer-bugs] [Bug 567748] New: http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/ext/pulse/pulsesink.c?r1=1.12&r2=1.13 is bogus

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=567748

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: http://webcvs.freedesktop.org/gstreamer/gst-plugins-
                    good/ext/pulse/pulsesink.c?r1=1.12&r2=1.13 is bogus
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lennart at poettering.net
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
I am pretty sure that this commit is bogus:

http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/ext/pulse/pulsesink.c?r1=1.12&r2=1.13

The newly introduced mutex is taken only when the threaded mainloop lock is
taen as well. As such it is a "submutex" for another mutex and hence redundant.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=567748.