[gstreamer-bugs] [Bug 567874] [audiofx] Echo/Reverb filter

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=567874

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #2 from Tim-Philipp Müller  2009-01-19 10:50 UTC -------
Looks good at first glance, but haven't tried it yet. Random nitpi^Hthoughts
when glancing over the code:

 - the name: is 'audiodelay' really the most fitting name
   (rather than, say, 'audioreverb')? Just wondering since
   'delay' could also be interpreted to mean that the timestamps
   etc. were tweaked.

 - might be good to add a 'Since' marker to the
   element gtk-doc blurb

 - maybe move code in set_property:PROP_DELAY to a helper func
   (somehow doesn't seem the right place to set up this stuff
   anyway)?

 - _get_property should take transform lock too, no? (get+set
   may theoretically be done concurrently from different
   threads)

 - bit sad that it's not enough to implement ::process(), but
   that's not really the element's fault I guess :)

I say put it in when/if you think it's ready.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=567874.