[gstreamer-bugs] [Bug 568836] PATCH: add seaking support to asfdemux when in push mode.

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=568836

  GStreamer | gst-plugins-ugly | Ver: 0.10.10

Hans de Goede changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW




------- Comment #4 from Hans de Goede  2009-01-25 12:48 UTC -------
(In reply to comment #3)
> The patch looks fine but unfortunately doesn't apply to latest version in GIT.
> Could you update it? :)

Erm, !@#$, I thought that gst-plugins-bad-0.10.10 already had the push / pull
based code paths unification patch (my fault). Anyways rebased (and retested)
patch attached.

I've split it in 2, the first patch makes asfpacket.c drop (the current payload
and the rest of) a packet when the replicated data length is invalid, instead
of continuing with an invalid timestamp and an uninitialized payload.mo_size.

I did this because I noticed the timestamp was checked for validity in certain
places, but used without checks in many others, so this seems the best thing to
do, esp. given the warning already issued when this happens:
"invalid replicated data length, very bad" This warning does not sound like a
good situation to keep processing the rest of the packet, hence my change to
drop it.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=568836.