[gstreamer-bugs] [Bug 587676] New: Call tzset() before localtime_r(), in e.g. gst-plugins-base/ext/pango/gstclockoverlay.c

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=587676

  GStreamer | gst-plugins-base | Ver: 0.10.22
           Summary: Call tzset() before localtime_r(), in e.g. gst-plugins-
                    base/ext/pango/gstclockoverlay.c
           Product: GStreamer
           Version: 0.10.22
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: hp at gcc.gnu.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


POSIX and your local friendly ctime(3) manual entry says that localtime_r isn't
required to set the state variables that define the current timezone.  Indeed,
glibc (at least 2.9) doesn't do this for subsequent calls.  The effect is that
if the system timezone is changed for a running program between two calls to
gst_clock_overlay_render_time, it won't be noticed.  For glibc, changing the
timezone equals /etc/localtime being modified.

The patch does the obvious thing.  It is however untested, as the real culprit
for the local scenario was not clockoverlay (not used) but other, local code at
Axis Communications, but which had the same bug(!)  (And the real bug is of
course that there's no tzset_r or similar, but that's another story.) The local
code was an import of 0.10.22.

I have not searched for presence of this bug in any other related code in this
or other GNOME components.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=587676.