[gstreamer-bugs] [Bug 525743] support for kate subtitle streams

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=525743

  GStreamer | gst-plugins-bad | Ver: 0.10.x

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137614|none                        |committed
               Flag|                            |
 Attachment #137615|none                        |committed
               Flag|                            |
 Attachment #137616|none                        |committed
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|support for subtitles as    |support for kate subtitle
                   |kate streams                |streams
   Target Milestone|HEAD                        |0.10.13




------- Comment #48 from Tim-Philipp Müller  2009-07-19 23:02 UTC -------
Ok, here it goes:

commit 2f7ec508993fd8f8a5f3b343b5873ef09069154a
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 23:45:02 2009 +0100

    docs: add inspect info for kate plugin

    Should fix the docs build.

commit 4728d7f18eff48760ff2e753142b7313eaf552d1
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 23:35:05 2009 +0100

    kate: add some FIXMEs

commit faf2d0469691a0f357cf6a4c048cf774ddf5b990
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 23:32:07 2009 +0100

    katedec: demote to GST_RANK_NONE for now

    There are still some autoplugging issues to sort out, and it needs
    some testing.

commit 0d16612717860fff76a9c1889d47f7f5fe0fbf7c
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 23:29:19 2009 +0100

    checks: add kate unit tests to valgrind blacklist for now

    And add check binary to ignore list.

commit 3f347c7edd0796fb033bb58f15017f1f6c6c5ebe
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 23:16:07 2009 +0100

    kate: make sure to free some more stuff

commit 71efbb1e73a557d50093ccaf2ecc47009b7edd95
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Jul 19 22:29:19 2009 +0100

    kate: fix up for additional subtitle/x-kate media type

commit 71e6bbd19fa1845dc07abc561b1ca5a71ae59d60
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Mon Jul 13 22:38:43 2009 +0100

    kate: remove local kate typefinder, use the one in -base

commit ce0d40b634a08aec047f8fd3fb059c1eb4480e1c
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Fri Jul 10 18:45:28 2009 +0100

    kate: change media type to subtitle/x-kate and update define accordingly

commit e88984ccbd4b2b7b5527cbc3ff488c5c85bb1e97
Author: Vincent Penquerc'h <ogg.k.ogg.k at googlemail.com>
Date:   Sun Feb 15 18:35:04 2009 +0000

    add new Kate plugin, for Kate overlay streams

    katedec: Kate decoder (text only)
    kateenc: Kate encoder (text and DVD SPU only)
    katetag: Kate tagger
    kateparse: Kate parser
    tiger: Kate renderer using the Tiger rendering library

    Fixes #525743.


I'm sure I've introduced an issue or two with the media type change (apologies
in advance), but I don't think I'll find those any sooner by keeping the code
on my harddrive. Also demoted the decoder to RANK_NONE for now until the
subtitle/subpicture overlay stuff in playbin(2) is sorted out.

It'd be great if you could make the unit tests valgrind clean at some point
(there seem to be a few minor mem leaks, and also a
jump-depends-onuninitialised-memory issue in the test_kate_encode_spu test).
I've also had the encode_spu test segfault once, but never managed to reproduce
that again.

Btw, whenever you return GST_FLOW_ERROR, you should post some sort of error
message on the bus, otherwise the user will just get to see a generic 'internal
flow error' message from the source element or demuxer, and won't have the
slightest idea where that comes from. Something like this should do the job:
  GST_ELEMENT_ERROR (encoder, STREAM, ENCODE, (NULL), ("debug message"));


Thanks for the patches and your patience!


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=525743.