[gstreamer-bugs] [Bug 578612] [flacdec] seek on flac file sometimes triggers flac decoder ABORT

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=578612

  GStreamer | gst-plugins-good | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138933|none                        |committed
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
           Severity|blocker                     |critical
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.16




------- Comment #6 from Tim-Philipp Müller  2009-07-21 19:46 UTC -------
commit 375976c847b80ab40ff30e1e5cef91ff12bddf50
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Tue Jul 21 19:46:55 2009 +0100

    flacdec: fix intermittent FLAC__STREAM_DECODER_ABORTED errors when seeking

    When seeking in a local flac file (ie. operating pull-based), the decoder
    would often just error out after the loop function sees a DECODER_ABORTED
    status. This, however, is the read callback's way of telling our loop
    function that pull_range failed and streaming should stop, in this case
    because of the flush-start event that the seek handler pushed upstream
    from the seeking thread. Handle this slightly better by storing the last
    flow return from pull_range, so the loop function can evaluate it properly
    when it encounters a DECODER_ABORTED and take the right action.

    Fixes #578612.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=578612.