[gstreamer-bugs] [Bug 589314] [basetransform] clears GAP flag in passthrough mode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=589314

  GStreamer | gstreamer (core) | Ver: git




------- Comment #5 from Kipp  2009-07-22 18:11 UTC -------
Is this a good approach?  Initially I was going to submit this as a
basetransform bug, too, but then I thought that even a pass-through element
might not be gap-aware.  For example, a pass-through element might be doing
something with the data as is goes through, like measuring a spectrum or
something, and the element might not know what to do with a gap.  It seems to
me that "is pass-through" and "is gap aware" really are two independent
properties of an element.

Maybe what should happen is that "is pass-through" and "is gap-aware" should
remain independent properties of a sub-class, but a check should be added to
the basetransform class that if a sub-class has set the pass-through flag and
has *not* set the gap-aware flag and a gap buffer is seen on the sink pad, then
the basetransform class raises a "not supported" error.  That way elements that
are not gap aware are prevented from accidentally processing data they don't
understand, and if an element is gap aware but its maintainer has forgotten to
say so in the init method then they'll find out from the error message and be
reminded to fix it.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=589314.