[gstreamer-bugs] [Bug 589609] New: [PATCH] fix dvdspu crash when subtitles do not fit the incoming video

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=589609

  GStreamer | gst-plugins-bad | Ver: git
           Summary: [PATCH] fix dvdspu crash when subtitles do not fit the
                    incoming video
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: critical
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ogg.k.ogg.k at googlemail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
If overlaying SPU images onto an incoming video, where the video is smaller
than the original one, and the SPUs do not fit, dvdspu may crash.


Steps to reproduce:
1. Apply the Kate patch to Thoggen (so, meant for Tim-Phillip Muller only for
now I suppose :))
2. Encode a DVD at a low resolution, selecting at least one SPU stream
3. Play back that video, using katedec and dvdspu


Actual results:
dvdspu may crash when trying to display SPUs outside the video.

Expected results:
A lack of crash. Moving and/or scaling SPUs would be nice too.


Does this happen every time?
For some test cases, yes.


Other information:
Patch attached.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=589609.