[gstreamer-bugs] [Bug 589797] alsasrc does not set GstAlsaSrc->handle to NULL after snd_pcm_close. causes crashes from places like gst_alsa_find_device_name

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=589797

  GStreamer | gst-plugins-base | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #139269|accepted-commit_now         |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24




------- Comment #4 from Tim-Philipp Müller  2009-07-27 13:37 UTC -------
commit 01e0fdd86c65123130147f64be33606bf2cca26b
Author: Balachandran C <balachandran_c at rediffmail.com>
Date:   Mon Jul 27 10:29:27 2009 +0100

    alsasrc: set alsasrc->handle back to NULL when closing device

    Fixes crashes in gst_alsa_find_device_name() when probing or
    reading the device-name property (e.g. when doing a dot-file
    dump). Fixes #589797.

(Ignored the error handling issue here; not sure if this will ever be
triggered, but even if I'm not sure if it's better to just leak the descriptor
and reset the handle to NULL like alsasrc currently does, or to keep the handle
open and return FALSE like alsasink does.)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=589797.