[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=586570

  GStreamer | gst-plugins-base | Ver: git




------- Comment #5 from Sebastian Dröge  2009-07-28 19:38 UTC -------
I'm not 100% conviced by this patch ;)

You're setting the output to zeroes if the gap can be skipped but the resampler
internal filter line will still have the old input data. Won't this result in
suboptimal output if processing continues because it doesn't interpolate from
silence but from the older input data?

Then you drain the resampler. Draining the resampler will result in suboptimal
output in the last few samples. Is this important here or will these last few
samples always be silence (from the GAP buffer)?

And then I wonder if draining the resampler and then continue using it later
won't introduce additional latency.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=586570.