[gstreamer-bugs] [Bug 586957] [ffdemux_ape] APE file metadata not retained during transcode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=586957

  GStreamer | gst-ffmpeg | Ver: 0.10.22

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
             Status|UNCONFIRMED                 |RESOLVED
          Component|don't know                  |gst-ffmpeg
         Resolution|                            |FIXED
            Summary|APE file metadata not       |[ffdemux_ape] APE file
                   |retained during transcode   |metadata not retained during
                   |                            |transcode
   Target Milestone|HEAD                        |0.10.9




------- Comment #1 from Tim-Philipp Müller  2009-07-28 22:59 UTC -------
This should fix it:

 commit d917f59a84b1d81c14ed7642ab04d254a97838d2
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Tue Jul 28 23:21:11 2009 +0100

    ffmpegdemux: cache events from upstream and re-send them later

    Cache any events we get from upstream before we're open, especially
    tag events we may be getting from apedemux/id3demux or the like, and
    push them downstream later when we've added our pads instead of just
    dropping them silently. Fixes transcoding tags for Monkey's Audio
    Files with preceding APE or ID3v2 tags (#586957). Add minimal unit
    test for this.

    Also push stream tags later after the global tags and the newsegment
    event rather than right after creating the pad.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=586957.