[gstreamer-bugs] [Bug 584252] enhancements to OSSv4 plugin

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584252

  GStreamer | gst-plugins-bad | Ver: 0.10.x

Brian Cameron changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135597|0                           |1
        is obsolete|                            |




------- Comment #3 from Brian Cameron  2009-06-03 18:23 UTC -------
Created an attachment (id=135901)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=135901&action=view)
updated patch


Note that many of the changes in this patch are related to adding new flags to
gst-plugins-base.  Refer:

  http://bugzilla.gnome.org/show_bug.cgi?id=570832
  http://bugzilla.gnome.org/show_bug.cgi?id=571106

Now that these changes are upstream, it would be good to support the new flags
in the OSSv4 plugin.

I have attached an updated patch.  I believe this updated patch cleans up the
code so it conforms to the style and removes some unnecessary changes.

Here is some detail on the changes:

1) oss4-audio.c is modified to simplify the fragsize computation.

2) oss4-mixer-slider.c is modified to support the new mixer-related flag and 
   also contains this change:

       if (mute) {
  +      /* make sure the current volume values get saved. */
  +      gst_oss4_mixer_slider_get_volume (s, s->volumes);
         volume = 0;
       } else {

  This change fixes a problem where the volumes weren't getting saved before
  muting for the first time.  Calling gst_oss4_mixer_slider_get_volume makes
  sure the volumes are cached before setting to 0.  Otherwise, when you mute
  and then unmute, the volume wouldn't get restored.

3) oss4-mixer.c contains improvements on how mixer labels are translated,
   the GST_OSS4_MIXER_WATCH_INTERVAL was changed from 500 to 150ms. the
   guess_master code was improved, and support for the new flags.

4) oss4-mixer-switch now supports the new mute-related flag.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584252.