[gstreamer-bugs] [Bug 585708] [adder] Wrong handling of flushing seeks

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=585708

  GStreamer | gst-plugins-base | Ver: git




------- Comment #3 from Edward Hervey  2009-06-15 05:34 UTC -------
(In reply to comment #1)
> Regarding the 2nd of my commits, it should be if (!result). Let me explain the
> problem at the time of the change:
> 
> If one conncted a live-src to adder and send a flushing seek, it did a flush
> start, the seek failed and no one did a flush stop. Thus the pipeline never
> played. With git HEAD it does not happen anymore. I am writing tests for the
> scenarios right now and then will see if I can use git bisect to find what
> fixed it and when.
> 

The fact that live sources didn't do the corresponding flush stop was
definitely a bug. So if that's fixed it's all good now and that hack should go
away.

The question is ... how should adder react if upstream failed to seek ? imho...
it should stop all seeking and return False downstream.

In any case.. it should not break behaviour for the cases where you only have
seekable sources upstream.

BTW, if you're using live sources... wouldn't liveadder from -bad be a better
choice ?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=585708.