[gstreamer-bugs] [Bug 585848] Let's revive the test suite

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=585848

  GStreamer | gst-sharp | Ver: git




------- Comment #3 from Sebastian Dröge  2009-06-16 08:32 UTC -------
Some comments:

0001 - You remove some test cases but they do more than just testing the
       refcounts (i.e. TestAddRemovePad)
     - Some tests were commented out before, maybe we can activate them again
       and remove the refcount checks and they're useful ;)

0002 - I'm not sure but maybe the Dispose() calls could expose
       owernship/refcount issues because we might dispose an instance
       that we don't own anymore. Or does nunit make sure that the GC is
       called at the end of every test?

0003 - The Bin test that iterates over the children could also use the
       Elements, etc properties that provide an IEnumerable instead of using
       the ChildProxy interface. But this is of course fine too :)

0005 - What exactly is the problem with the Application.Deinit() calls?

And a general comment, IMHO we shouldn't ignore crashing tests as this way they
might be forgotten :)

Good work otherwise... I'll handle the comments above unless you want to
provide a new patch :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=585848.