[gstreamer-bugs] [Bug 573823] New: pad block callback if it is re-blocked while the previous callback is running

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=573823

  GStreamer | gstreamer (core) | Ver: git
           Summary: pad block callback if it is re-blocked while the
                    previous callback is running
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tester at tester.ca
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


There is a race if while a pad block callback if executed, after it has done
gst_pad_set_blocked_sync(FALSE), another thread re-sets it to true. The pad
will never be unblocked and the second callback will never be called.

I'm attaching a patch, but I'm not sure its the right approach, maybe a counter
would be better.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=573823.