[gstreamer-bugs] [Bug 574838] seeking can deadlock adder

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=574838

  GStreamer | gst-plugins-base | Ver: git




------- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev)  2009-03-14 20:54 UTC -------
Created an attachment (id=130680)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=130680&action=view)
use adder obecjt lock

The deadlock happens between:
adder: gst_adder_src_event()/GST_EVENT_SEEK/GST_OBJECT_LOCK (adder->collect);
and
collectpads: gst_collect_pads_chain/GST_COLLECT_PADS_WAIT (pads);

In the patch I added logging and some more return value handling. The fix for
the problem is to use GST_OBJECT_LOCK (adder) to protect adder->segment_pending
in gst_adder_src_event() and gst_adder_collected() instead of the object-lock
on adder->collect.

Is that the right fix?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=574838.