[gstreamer-bugs] [Bug 581292] New: LAME plugin doesn't correctly flush the encoder on EOS/FLUSH events

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581292

  GStreamer | gst-plugins-ugly | Ver: git
           Summary: LAME plugin doesn't correctly flush the encoder on
                    EOS/FLUSH events
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: t.i.m at zen.co.uk, slomo at circular-chaos.org,
                    david.joaquim at gmail.com
 BugsThisDependsOn: 494528
     GNOME version: Unspecified
   GNOME milestone: Unspecified


+++ This bug was initially created as a clone of Bug #494528 +++

*on GST_EVENT_FLUSH_STOP, you are using a buffer of 7200. Why not always using
the same buffer value, both when encoding and on closing? (mp3_buffer_size =
1.25 * num_samples + 7200)
7200 will sometimes not be big enough.

The same issue is on EOS event.

Also on FLUSH_START we should probably call encode_flush_nogap() and send the
resulting data downstream and not just drop it in FLUSH_STOP.

The problem now is, that we need to either provide a large enough buffer to the
flush functions to keep all encoded data (otherwise we drop some audio) or to
call it until no data is left.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581292.