[gstreamer-bugs] [Bug 581292] LAME plugin doesn't correctly flush the encoder on EOS/FLUSH events

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581292

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #2 from Gabriel Bouvigne  2009-05-04 13:57 UTC -------
I asked Robert (current maintainer) about it, and here are the results:

* the (mp3_buffer_size = 1.25 * num_samples + 7200) value for encoding is quite
conservative, and should be more than enough as long as you don't feed more
than Lame's internal buffer at once (about 144000 bytes large)

* for the flush function, 7200 should be more than enough, provided you
respected the upper condition.

* flush will return -1 if the provided buffer was not big enough, but
unfortunately there is NO way to retry.

* the fact that the flushing function doesn't 0 after the first call is likely
a bug, as it is not supposed to be called more than once

Btw, in your case I don't think you should care about the xxx_nogap functions.

So it seems to be that there is no flushing issue right now within your plugin
(and it was a false report from my side). The only potential issue would be the
very rare case where the gstreamer input buffer is bigger than Lame's internal
buffer.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581292.