[gstreamer-bugs] [Bug 579692] mp3_type_find is over-optimistic

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=579692

  GStreamer | gst-plugins-base | Ver: 0.10.21

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org
 Attachment #133030|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24




------- Comment #4 from Sebastian Dröge  2009-05-07 13:01 UTC -------
Thanks, committed locally and will push after the freeze.

commit 9eebc2249931c04cff0ce3fcf3546863e8f65c07
Author: Arnout Vandecappelle <arnout at mind.be>
Date:   Thu May 7 14:59:36 2009 +0200

    typefindfunctions: made mp3_type_find less aggressive

    mp3_type_find could suggest already when only a single valid header
    was found, if it ran out of data before the end of the next frame.
    Therefore, ignore the last found frame if it was incomplete.
    Fixes bug #579692.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=579692.