[gstreamer-bugs] [Bug 582420] flacdec unit test broken on PPC

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Wed May 13 01:29:45 PDT 2009


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582420

  GStreamer | gst-plugins-good | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134537|accepted-commit_now         |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15




------- Comment #2 from Tim-Philipp Müller  2009-05-13 08:29 UTC -------
commit 0c4b6ee2860e30c40f25bbb5c1c139db1eea69b7
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed May 13 09:24:26 2009 +0100

    checks: fix flacdec unit tests on big-endian machines and under valgrind

    Flacdec outputs 16-bit samples, so let's check if the value of the first
    sample is what we expect rather than just the first byte, which may be
    different from what we expect depending on the host's endianness. Fixes
    the flacdec unit tests on PPC. Also fix a bunch of leaks in the unit
    tests to make valgrind happy. Fixes #582420.

commit 8accf2704bba2eae29874de8bb409ea67599500e
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed May 13 09:18:07 2009 +0100

    flacdec: fix buffer leak

    gst_buffer_replace() will take its own ref, so we still have
    to unref the buffer if we don't need it any longer.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582420.




More information about the Gstreamer-bugs mailing list