[gstreamer-bugs] [Bug 582564] [controller] Use ordered GSequence instead of GList in the interpolation control source

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582564

  GStreamer | gstreamer (core) | Ver: git

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




------- Comment #9 from Stefan Kost (gstreamer, gtkdoc dev)  2009-05-22 10:52 UTC -------
gstinterpolation.c still has a lot of
iter = g_sequence_get_begin_iter (self->priv->values);
where we don't check that self->priv->values!=NULL.

Regarding that I wonder if we just want to create the sequence when creating
the control-source, to avoid the checks.

Then there is code like this:
  iter = g_sequence_get_begin_iter (self->priv->values); \
  cp = g_sequence_get (iter); \
or this
  iter = g_sequence_iter_next (iter); \
  cp = g_sequence_get (iter); \
where we probably need to cehck the iter against NULL :/


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582564.