[gstreamer-bugs] [Bug 584020] New: [playbin2] inadvertently resets configured audio/video sinks

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584020

  GStreamer | gst-plugins-base | Ver: git
           Summary: [playbin2] inadvertently resets configured audio/video
                    sinks
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Wanted to make totem output to SPDIF, but somehow totem kept outputting to the
normal speakers. Turns out the configured audiosink(bin) is inadvertently being
discarded in no_more_pads():

  ...
  /* if we have custom sinks, configure them now */
  GST_SOURCE_GROUP_LOCK (group);
  GST_LOG_OBJECT (playbin, "setting custom audio sink %p",
      group->audio_sink);
  gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_AUDIO,
      group->audio_sink);
  GST_LOG_OBJECT (playbin, "setting custom video sink %p", group->video_sink);
  gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_VIDEO,
      group->video_sink);
  ...

Since no custom sinks (that handle e.g. mp3 or so) are being used here, this
will just overwrite the configured sinks with NULL, which means playbin2 will
default to autoaudiosink/autovideosink as if the gconf sinks were never set up.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584020.