[gstreamer-bugs] [Bug 596832] configurable buffer alignment

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Oct 2 00:36:08 PDT 2009


https://bugzilla.gnome.org/show_bug.cgi?id=596832
  GStreamer | gstreamer (core) | git

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2009-10-02 07:36:02 UTC ---
(In reply to comment #6)
> Created an attachment (id=144568)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=144568) [details]
> use posix memalign to allocate buffers
> 
> This version of the patch makes the tests pass again. I totally agree that
> pagesize is overkill for most platforms, 32 bytes alignment seems to be a good
> default.

That patch still uses getpagesize() ;)

IMHO you should make this configurable: --with-buffer-alignment=[0,N,pagesize],
default=32

Where 0 would simply fall back to g_malloc, N would be a hardcoded number and
pagesize would use the return value of getpagesize(). What do you think?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list