[gstreamer-bugs] [Bug 574434] [camerabin] Changing default video/audio source for Windows

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=574434
  GStreamer | gst-plugins-bad | 0.10.10

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Changing default            |[camerabin] Changing
                   |video/audio source for      |default video/audio source
                   |Windows                     |for Windows

--- Comment #11 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2009-10-09 15:34:39 UTC ---
I think we need to do the same thing as in playbin (playsink.c)

  if (playsink->video_sink) {
    GST_DEBUG_OBJECT (playsink, "trying configured videosink");
    chain->sink = try_element (playsink, playsink->video_sink, FALSE);
  } else {
    /* only try fallback if no specific sink was chosen */
    if (chain->sink == NULL) {
      GST_DEBUG_OBJECT (playsink, "trying autovideosink");
      elem = gst_element_factory_make ("autovideosink", "videosink");
      chain->sink = try_element (playsink, elem, TRUE);
    }
    if (chain->sink == NULL) {
      /* if default sink from config.h is different then try it too */
      if (strcmp (DEFAULT_VIDEOSINK, "autovideosink")) {
        GST_DEBUG_OBJECT (playsink, "trying " DEFAULT_VIDEOSINK);
        elem = gst_element_factory_make (DEFAULT_VIDEOSINK, "videosink");
        chain->sink = try_element (playsink, elem, TRUE);
      }
    }
  }
  if (chain->sink == NULL)
    goto no_sinks;

Speaking of that, it should probably first try DEFAULT_VIDEOSINK and use
autovideosink as a last resort (if its different from DEFAULT_VIDEOSINK).

This way a packager can e.g. configure --with-default-videosink=gconfvideosink
for gnome or --with-default-videosink=directdrawsink on windows.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.