[gstreamer-bugs] [Bug 590362] x264enc wrong duration hence qtmux fails

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=590362
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145388|none                        |reviewed
             status|                            |

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2009-10-14 08:01:56 UTC ---
(From update of attachment 145388)
Some minor nitpicks:

>From: Thiago Sousa Santos <thiagoss at darkwater.(none)>

You should set up a proper e-mail address, see the GitDevelopersGuide wiki page
for details (somewhere at the end).

>@@ -938,11 +940,15 @@ gst_v4l2src_create (GstPushSrc * src, GstBuffer ** buf)
>           timestamp -= latency;
>         else
>           timestamp = 0;
>+
>+        /* estimate duration from framerate */
>+        duration = (GST_SECOND * v4l2src->fps_d) / v4l2src->fps_n;
>       }
>     }

We usually use utility functions like gst_util_uint64_scale_int() for these
kind of calculations to avoid overflows (see a few lines above). Not it's
likely to matter much here, but still. Also, in this case a

  duration = latency

would probably suffice :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.