[gstreamer-bugs] [Bug 597497] can't play a redirecting .mov file via playbin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=597497
  GStreamer | don't know | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2009-10-15 14:31:04 UTC ---
Not really familiar with how this all fits together, but here are some random
comments nevertheless:

 - could this be split out into a separate function? I think
   parse_trak() is already quite long

 - it looks like you're assuming that the URI string is
   NUL-terminated, which you shouldn't. Better 
   g_strndup() and then later g_free() the string to
   make absolutely sure it has a terminator.

 - might want to check that the URI is a valid uri
   and/or looks like what you're looking for (do
   we only want URIs that redirect to rtsp://... ?)

 - how does this work policy-wise with these URIs?
   Do they sometimes appear in perfectly valid
   and playable files as extra information on the
   side (in which case the app shouldn't act on the
   redirect message) or can we assume that if
   there is such a redirect that's it? I don't really
   know what we do now, but we probably should
   think about this. Currently totem acts immediately
   on a redirect message, IIRC.

 - if there are multiple URIs, should they be collected
   and posted in one single message? (like the other
   redirect code does)

 - does that 4-byte value that you skip make sense
   if interpreted as bitrate?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.