[gstreamer-bugs] [Bug 598682] New: make check fails due to fpsdisplaysink if xvimagesink does not exist

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=598682
  GStreamer | gst-plugins-bad | git

           Summary: make check fails due to fpsdisplaysink if xvimagesink
                    does not exist
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: pkj at axis.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=145604)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=145604)
Fail rather than use a sink which is NULL

In case fpsdisplaysink cannot create an xvimagesink during its initialization,
it will fail later when trying to change state. This causes the generic/states
check test to fail. The attached patch solves the problem. However, as
suggested by Edward Hervey, a better solution would be to move the
initialization to the NULL=>READY state transition.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.