[gstreamer-bugs] [Bug 595231] [pulsesink] Lowers volume after every new track

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595231
  GStreamer | gst-plugins-good | 0.10.15

--- Comment #27 from Lennart Poettering <lennart at poettering.net> 2009-10-17 18:59:51 UTC ---
(In reply to comment #26)
> (In reply to comment #24)
> > (In reply to comment #21)
> > > Also, shouldn't volume_set and mute_set be set to FALSE after
> > > pa_context_set_sink_input_volume()?
> > 
> > Not necessary. We only ever set those flags *before* the stream is setup --
> > where we reset them again. While the stream is established the flags are not
> > used at all anymore, are hence neither set, nor reset.
> 
> Not really, they're also set in gst_pulsesink_set_volume(), which is called
> whenever the "volume" property is set (and the same for mute of course).

No. Look more closely! My patch made sure that they are only set when the
stream is not set up yet. If it is set up we just call
pa_sink_input_set_volume() and do not store the volume locally.

> > I'll prep a patch for gst as soon as this new flag is stabilizied.
> 
> Wouldn't it be better then to *not* set the mute/volumes in stream setup and
> only afterwards? Otherwise the volume property has two different meanings,
> depending on the current state.... and that's not really nice.

It only has a different meaning for some sinks, not for all. That said, this is
indeed ugly, which is why I have added a flag to the PA API that allows clients
to say if they want relative or absolute volumes. However without this flag you
simply cannot say what you get, neither during stream creation nor while the
stream exists. This is a weakness of the API. Will be fixed. 

I am contemplating making an additional change in PA itself: by default make
volumes configured by clients absolute. That would eliminate the uncertainty
too. And I wouldn't even consider that breakage since before that we did no
specify the type of volumes for streams at all.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.