[gstreamer-bugs] [Bug 598936] DKS subtitle format

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 19 07:43:42 PDT 2009


https://bugzilla.gnome.org/show_bug.cgi?id=598936
  GStreamer | gst-plugins-base | git

--- Comment #1 from Iago Toral <itoral at igalia.com> 2009-10-19 14:43:39 UTC ---
Created an attachment (id=145785)
 View: https://bugzilla.gnome.org/attachment.cgi?id=145785
 Review: https://bugzilla.gnome.org/review?bug=598936&attachment=145785

Implements support for DKS subtitle format in the subparse element

Patch attached.

Note for reviewers: DKS uses [br] for line breaks, just like subviewer 2.0
subtitles. The function subviewer_unescape_newlines replaces [br] with '\n' but
instead of reusing this function I copied it with the name
dks_unescape_newlines. Probably this was not a good idea, maybe renaming
subviewer_unescape_newlines to something else that does not suggest that the
function is subviewer specific is a better approach.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list